[4.0] remove popover #17071
[4.0] remove popover #17071
Conversation
This is a proof of concept for joomla#17044 to remove the redundant popovers. PURELY for the purpose of testing this concept I have quickly displayed the remaining popover as inline text - THIS PART IS NOT FOR REVIEW - it is just to demonstrate how few remaining descriptions we will have In addition you will notice that the remainining descriptions are not very good. They are manuals not tips, hints or descritpions and can be drastically reduced or rewritten. AGAIN this text is not for review here
|
+1 |
| COM_BANNERS_FIELD_ALT_LABEL="Alt Text" | ||
| COM_BANNERS_FIELD_BANNEROWNPREFIX_DESC="Use own prefix or the client prefix." |
There was a problem hiding this comment.
OK So with switch removing this becomes not possible. There's nothing stating that off means client prefix (nor is it obvious)
There was a problem hiding this comment.
This is a good example of where the existing label is simply wrong
There was a problem hiding this comment.
Then let's fix the label now ;) We can't remove the description if it's the only thing explaining what's going on :)
| @@ -69,73 +69,40 @@ COM_BANNERS_ERR_ZIP_CREATE_FAILURE="Zip create failure" | |||
| COM_BANNERS_ERR_ZIP_DELETE_FAILURE="Zip delete failure" | |||
| COM_BANNERS_ERROR_UNIQUE_ALIAS="Another Banner from this category has the same alias (remember it may be a trashed item)." | |||
| COM_BANNERS_EXTRA="Additional Information" | |||
| COM_BANNERS_FIELD_ALIAS_DESC="The alias is for internal use only. Leave this blank and Joomla will fill in a default value from the title. It has to be unique for each banner in the same category." | |||
There was a problem hiding this comment.
It has to be unique for each banner in the same category does this not need to be stated somewhere?
There was a problem hiding this comment.
Why would we need to state it. In most cases it it will be automatically generated and if someone does it manually and uses an existing alias then they will get an error message
There was a problem hiding this comment.
If you have a clue what it does then I would be happy to but I have zero clue
| COM_BANNERS_FIELD_IMPMADE_LABEL="Total Impressions" | ||
| COM_BANNERS_FIELD_IMPTOTAL_DESC="Total limit of impressions defined for the banner." | ||
| COM_BANNERS_FIELD_IMPTOTAL_LABEL="Max. Impressions" |
There was a problem hiding this comment.
Is max the same as total limit?
There was a problem hiding this comment.
Again an example of existing unclear labels
Max Impressions is the limit
Total Impressions is the current count
|
Just gone through the list of strings (haven't matched them to the XML files). Largely this looks ok although there's a couple where I'm a bit uncertain |
brianteeman
changed the title
|
ok i am done. i have updated the original post and this is ready for review. Please read the notes carefully |
|
RTC @wilsonge please merge this to proceed with our road map |
|
From what I can tell the drone issue is unrelated |
|
@brianteeman it is unrelated and it was patched in couple PRs that never made it to the core |
|
If you get conflicts done here I'll get it merged |
|
What again :( |
|
It's the PR of your's I merged this morning :) I'll get this merged next! |
|
Yes I know.i am just pulling your chain |
|
Conflicts resolved - hopefully for the last time. |
Only for this PR I'm afraid ;) |
|
Thanks |
This is a pr for #17044 to remove the redundant popovers.
PURELY for the purpose of testing this concept I have quickly displayed the remaining popover as inline text - THIS PART IS NOT FOR REVIEW - it is just to demonstrate how few remaining descriptions we will have
In most cases the description could be simply removed
In some cases by adjusting the label the description could be removed.
Of the remaining descriptions some have been updated to remove redundancy and duplication but they need further review/testing but that is not part of this pr
Strings that are no longer used have been deleted unless they are in a global language file
References to labels and descriptions in Filters have been removed as they were neither being used not did 99% of them even exist. NOTE I did not look at the filters in /components as i could not see where or if they are even being used